-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changes spacing of icons and adds info for element details #31
changes spacing of icons and adds info for element details #31
Conversation
logger was updated, but doesn't have enough jsdoced stuff. come on man. |
Yeah most of the tests are failing. All of the tests that rely on anything where logger is injected will have a problem. |
Most of the tests are passing again. They were failing because of the Only test suite failing to run is selector-finder.puppeteer.test.js: The error below may be caused by using the wrong test environment, see https://jestjs.io/docs/configuration#testenvironment-string.
Consider using the "jsdom" test environment.
ReferenceError: navigator is not defined
at node_modules/boxen/node_modules/chalk/source/vendor/supports-color/browser.js:4:2
at node_modules/boxen/node_modules/chalk/source/vendor/supports-color/browser.js:16:3 |
This could help get past some issues with jest using the environment-version of some libs
Finally got all tests passing with correctly importing the proper environment and then doing proper setup. Let's merge it! |
Adds a new dependency for making fancy boxes
Adds actual icons in the cli instead of whatever that was before.
Makes the final result a tad more colorful