Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge qspec funcs #1804

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Merge qspec funcs #1804

wants to merge 2 commits into from
+95 −207

Conversation

oerc0122
Copy link
Collaborator

@oerc0122 oerc0122 commented Jan 8, 2025

Merge separate implementation of computing qw from original data.

@oerc0122 oerc0122 added the Technical Debt code quality, unit tests, code duplicaton label Jan 8, 2025
@oerc0122 oerc0122 self-assigned this Jan 8, 2025
abuts
abuts approved these changes Jan 10, 2025
View reviewed changes
Copy link
Member

@abuts abuts left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like reasonable change. Should go ahead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abuts abuts abuts approved these changes

Assignees

@oerc0122 oerc0122

Labels
Technical Debt code quality, unit tests, code duplicaton
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oerc0122 @abuts