Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docs (Duc assigned) #1614

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Fix docs (Duc assigned) #1614

wants to merge 8 commits into from

Conversation

mducle
Copy link
Member

@mducle mducle commented Mar 21, 2024

This PR fixes the docs I was assigned:

Edit: In addition I've cleaned up the links between sections and some formatting errors and also removed the old example scripts in the manual/ folder which was not linked to anywhere else (and has been superseded by the example_scripts folder.

@mducle mducle added documentation This ticket relates to writing/updating documentation DO_NOT_CI Skip CI on this PR labels Mar 21, 2024
@mducle mducle force-pushed the duc_doc_changes branch from 29b6d13 to ca0b5ae Compare July 25, 2024 16:04
@mducle mducle marked this pull request as ready for review July 25, 2024 16:52
Generating data
===============
Generating the data
===================
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is to avoid a warning that there as a duplicate section title Generating data below.

- :ref:`IX_dataset_3d <manual/Changing_object_type:IX_dataset_3d>`
.. - :ref:`IX_dataset_1d <manual/Changing_object_type:IX_dataset_1d>`
.. - :ref:`IX_dataset_2d <manual/Changing_object_type:IX_dataset_2d>`
.. - :ref:`IX_dataset_3d <manual/Changing_object_type:IX_dataset_3d>`
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cmarooney-stfc Duly removed...

@@ -263,9 +259,9 @@ to add them together. In this case, you may decrease time of your ``plus`` opera
w_bg = sqw_eval(my_cut,@my_background,background_parameters);
w_sum = binary_op_manager(w_fg,w_bg,@plus,true);

Last parameter of ``binary_op_manager`` set to ``true`` disables sorting pixels in bins while performing binary operations.
If the last parameter of ``binary_op_manager`` is set to ``true`` it disables sorting pixels in bins while performing binary operations.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A cross-reference to the sorting operation applied would be useful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DO_NOT_CI Skip CI on this PR documentation This ticket relates to writing/updating documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants