Use a multimodule maven organisation for 2.x #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victornoel
force-pushed
the
multimodule-2.x
branch
3 times, most recently
from
8bff754
to
df716a4
Compare
|
OK. This one targets an existing branch, so yes, it makes sense to keep the existing Yes, pac4j v2.3.0 has a |
leleuj
approved these changes
Mar 21, 2018
| * | ||
| * @return value for {@link CallbackFilter#setSaveInSession(Boolean)} | ||
| */ | ||
| boolean[] saveInSession() default {}; |
There was a problem hiding this comment.
Why would you want something that can have the value null here?
The point of those annotations is that they allow the user to express themselves without over thinking: if they put a value it is used, if they do not, the default is used.
- Bump to pac4j 2.3.0 - Users should depend on jersey-pac4j or resteasy-pac4j - Users can still depend on jax-rs-pac4j for backward compatibility - Add saveInSession parameter for callback endpoints
victornoel
force-pushed
the
multimodule-2.x
branch
from
df716a4
to
3e846c3
Compare
|
I updated the PR, I will merge it later tonight except if you have other feedbacks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cf #37 for details on why
@pierre-l here it is for 2.x
@leleuj, two points:
org.pac4j.jax-rs-pac4jfor backward compatibilitysaveInSessionparameter for callback endpoints but it isn't there inCallbackLogic.perform, instead I set it on the logic itself, could you confirm that what I did is correct?