Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Retrieving Conversation by Name #162

Merged

Conversation

itsmechlark
Copy link
Contributor

No description provided.

@github-actions
Copy link

Marking this pull request as stale due to inactivity. This helps our maintainers find and focus on the active pull requests. If this pull request receives no comments in the next 30 days it will automatically be closed. Maintainers can also remove the stale label.

If this pull request was automatically closed and you feel this pull request should be reopened, we encourage creating a new pull request linking back to this one for added context. Thank you!

@github-actions github-actions bot added the stale label Feb 17, 2023
@pablovarela pablovarela marked this pull request as ready for review March 16, 2023 21:11
@pablovarela pablovarela self-requested a review as a code owner March 16, 2023 21:11
Copy link
Owner

@pablovarela pablovarela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am merging this. I had to do a couple of changes:

  1. Updated documentation as is_private is only uses when name attribute is set.
  2. updated new test to use name in the data source. The provided test was searching by ID.
  3. The test show a bug that didn't set channel_id when name is used

The tests could do with some refactoring but I don't have time now to do it.

Thanks a lot for your contribution!

Note: tests are not passing in this PR due to authentication issues but they pass just fine locally. They will work once merged.

@pablovarela pablovarela merged commit 1ff81b5 into pablovarela:master Mar 16, 2023
@pablovarela
Copy link
Owner

pablovarela commented Mar 16, 2023

This is now part of v1.2.0 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants