Replace instanceOf with Buffer.isBuffer() #24
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refi93
changed the title
refi93
changed the title
pabigot
pushed a commit
that referenced
this pull request
Apr 29, 2021
instanceOf check may fail in browser environment where multiple versions of the buffer package may be bundled together, hence resulting in different instances of Buffer being present in the code. A more resilient way of checking whether the parameter supplied is a buffer is the Buffer.isBuffer() method which I'm migrating to in this PR. From #24. Signed-off-by: Peter A. Bigot <[email protected]>
pabigot
pushed a commit
that referenced
this pull request
Apr 29, 2021
instanceOf check may fail in browser environment where multiple versions of the buffer package may be bundled together, hence resulting in different instances of Buffer being present in the code. A more resilient way of checking whether the parameter supplied is a buffer is the Buffer.isBuffer() method which I'm migrating to in this PR. From #24. Signed-off-by: Peter A. Bigot <[email protected]>
pabigot
pushed a commit
that referenced
this pull request
Apr 29, 2021
instanceOf check may fail in browser environment where multiple versions of the buffer package may be bundled together, hence resulting in different instances of Buffer being present in the code. A more resilient way of checking whether the parameter supplied is a buffer is the Buffer.isBuffer() method which I'm migrating to in this PR. From #24. Signed-off-by: Peter A. Bigot <[email protected]>
|
Thanks; I reworked the commit message description to be self-contained using your edited text above, and added the necessary release update content. This is now merged as 739d75a and seems to be published correctly. If you notice any problems please let me know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
instanceOfcheck may fail in browser environment where multiple versions of the buffer package may be bundled together, hence resulting in different instances of Buffer being present in the code. A more "resilient" way of checking whether the parameter supplied is a buffer is theBuffer.isBuffer()method which I'm migrating to in this PRTesting:
yarn testpassesmore info:
feross/buffer#154