Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Structure: support anonymous containers #8

Closed
pabigot opened this issue Nov 18, 2015 · 1 comment
Closed

Structure: support anonymous containers #8

pabigot opened this issue Nov 18, 2015 · 1 comment
Milestone
When Pigs Fly

Comments

@pabigot
Copy link
Owner

pabigot commented Nov 18, 2015

When a layout includes an anonymous Structure the layouts within that structure should be added directly to the object created using the parent layout.
@pabigot pabigot added this to the When Pigs Fly milestone Nov 20, 2015
pabigot added a commit that referenced this issue Nov 20, 2015
@pabigot
LayoutTest: add cases related to issue #8
24ec666 
It's entirely unclear how to accomplish this without breaking the simple
existing concept that the layouts are strictly defined, so we're just
adding the tests and leaving the issue open.
pabigot added a commit that referenced this issue Nov 22, 2015
@pabigot
Layout: remove destination object from decode method
54987e4 
This relates to issue #8 in that it provided a way to hide the true
structure by allowing fields within unions (but not structs) to be
placed in the parent object.  This is too confusing: the rule is that
Layout.decode always returns the decoded value; if that value is a
Union, then even if the variant in it is a number what gets returned is
an Object not the raw number.
@pabigot
Copy link
Owner Author

pabigot commented Nov 22, 2015

This pig will never fly.

@pabigot pabigot closed this as completed Nov 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
When Pigs Fly
Development

No branches or pull requests
1 participant
@pabigot