Add workingDirectory input #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @paambaati, any chance you can have a look at this? Thanks! |
|
Hi @vladjerca, @mattvv & @MartinNuc, can any of you take a look at this? Thanks! |
|
@arareko Nice addition, but it's on @paambaati to get this merged, don't know who else has merge rights on the repo 😋 |
|
@vladjerca thanks for the comment! hopefully @paambaati gets to see this then.. |
|
I'm so sorry folks, I'd been busy with work. I'm looking at this PR right now and you can expect it to be merged in the next few hours. |
paambaati
requested changes
Sep 22, 2020
|
@arareko Thanks a lot for this PR! I'll be following this up with tests. |
paambaati
added a commit
that referenced
this pull request
Sep 22, 2020
@paambaati I just saw you added the tests and released this feature along with a new version. Thanks so much. Cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When checking out multiple repos within a single GitHub workflow, the use of
pathbecomes necessary to keep things organized, but also creates the need to move across directories to accomplish certain tasks. In the case of running unit tests for a specific project folder, this usually leaves the resulting files in the directories where the test command was executed.Code Climate's
cc-test-reportbinary does not support pre-pending the path to the "location" of the coverage files, and also searches for a.git/directory in the current working directory. These two conditions make it necessary to run the binary within the proper location.GitHub actions’
usesstep does not allow specifying aworking-directoryin which to run the action being "used". At the same time, theusesstep doesn't seem to execute a shell (thus therunitem does not apply to it), hence thecdshell builtin is never available. Pre-pendingcd <path> &&to thecoverageCommandinput results in an error due to this.This patch adds a
workingDirectoryinput to this GH action, which allows changing to a custom working directory via Node.js’process.chdir()function. It also fixes a few places whereerror()was being passed non-string values, thus giving runtime errors.