Only add --prefix when prefix option was specified.
#131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`@actions/core`s `getInput` **always** returns a string ([see implementations](https://github.com/actions/toolkit/blob/%40actions/core%401.1.0/packages/core/src/core.ts#L72-L80). Prior to these changes, the logic: ```js if (!coveragePrefix && typeof coveragePrefix === 'string') { ``` Would only pass the `--prefix` argument when the action was *not* configured with a `prefix` option. This changes to ensure that we only specify `--prefix` when a `prefix` option was specified. In the default case (no `prefix` option) the passed `coveragePrefix` would be `""` which is falsey and would therefore avoid adding `--prefix`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@actions/coresgetInputalways returns a string (see implementation). Prior to these changes, the logic:Would only pass the
--prefixargument when the action was either configured with aprefix: ""or no prefix at all.This changes to ensure that we only specify
--prefixwhen aprefixoption was specified. In the default case (noprefixoption) the passedcoveragePrefixwould be""which is falsey and would therefore avoid adding--prefix.