could we add windows support? #665
Comments
|
Thanks for bringing this to my notice! I will bring Windows support shortly. You can track #666 for updates. |
|
@bboyle Please see codeclimate/test-reporter#517 (comment) While I've been slowly but steadily making progress on getting all tests to pass on Windows, the reporter supports only AMD distributions. I am not sure of what architecture you use, and what else is out there in the Windows world, as I'm primarily a *nix user, but this is something to keep in mind. |
|
that's an unusual choice by code climate 😅 I was planning to run it in a github action, so depends what github run here. Not sure if I can specify the CPU architecture but will find out (and send feedback to codeclimate if it's an issue). |
|
Weekend update – I think I have it ready to run on Windows, except for an unexplained issue where tests are failing on CI alone. I've raised it here – tape-testing/tape#593 |
|
I see how much work you're doing on it, thanks! |
BREAKING CHANGE: Support Windows, now that CodeClimate has released a Windows binary of the reporter – see codeclimate.com/changelog/7dd79ee1cf1af7141b2bd18b Fixes #665.
|
Please hold on while I fix my broken release process; raised at semantic-release/semantic-release#2788 |
# [5.0.0](v4.0.0...v5.0.0) (2023-07-06) ### Bug Fixes * **ci:** checkout EVERYTHING so semantic-release has all the data it could need ([a16dca5](a16dca5)) * **ci:** do not cancel all matrix builds for one ([1471593](1471593)) * **ci:** set up correct regex that replaces the 'v' prefixes for tags ([b3bcc0e](b3bcc0e)) * **core:** handle globs correctly in windows ([54ac87c](54ac87c)) * **core:** parse coverage path correctly on all platforms ([923001d](923001d)) * create hash from windows ([077e614](077e614)) * keep windows-style line endings for .bat files ([67549ff](67549ff)) * set up gitattributes to stop the line ending fuckery ([4246a36](4246a36)) * set up gitattributes to stop the line ending fuckery ([9181fd8](9181fd8)) * **tests:** additional windows-style test fixes ([def6f6d](def6f6d)) * **tests:** fix tests for Windows ([18e310b](18e310b)) * **tests:** fix the Windows path ([6e02942](6e02942)), closes [/github.com/tape-testing/tape/issues/593#issuecomment-1537292595](https://github.com//github.com/ljharb/tape/issues/593/issues/issuecomment-1537292595) * **tests:** make sure the special variable in script are quoted to make string comparison work ([c796f65](c796f65)) * **tests:** mock checksum verification too ([2befa84](2befa84)) * **tests:** more windows-specific test fixes ([de37362](de37362)) * **tests:** more windows-specific test fixes ([e44e0a3](e44e0a3)) * **tests:** more windows-specific test fixes ([0b2f6f8](0b2f6f8)) * **tests:** more windows-specific test fixes ([9a9184a](9a9184a)) * **tests:** more windows-specific test fixes ([1c1a7eb](1c1a7eb)) * **tests:** more windows-specific test fixes ([8d2edab](8d2edab)) * **tests:** more windows-specific test fixes ([e05d58f](e05d58f)) * **tests:** more windows-specific tests ([e9e87cc](e9e87cc)) * **tests:** more windows-specific tests ([13ff2e3](13ff2e3)) * **tests:** more windows-specific tests ([80aa61e](80aa61e)) * **tests:** more windows-specific tests ([498dee1](498dee1)) * **tests:** more windows-specific tests ([f4dff2a](f4dff2a)) * **tests:** more windows-specific tests ([4b48851](4b48851)) * **tests:** OS-agnostic line separators for all strings ([2fc4cc3](2fc4cc3)) * **tests:** remove windows-only test and start writing os-independent logic ([29cbd91](29cbd91)) * **tests:** run checksum verification pre-checks only for fixtures on their own target platforms ([4dc408b](4dc408b)) * **tests:** set up correct file mode on Windows ([4edff7e](4edff7e)) * **tests:** set up Windows fixtures ([c29289f](c29289f)) * **tests:** skip integration tests on unsupported platforms ([00e5b40](00e5b40)) * **tests:** try correcting extra spaces in checksum files generated on Windows ([edc5e97](edc5e97)) * try LF-only line endings for all files ([e2c94ee](e2c94ee)) * **util:** follow redirects in fetch ([a258bd9](a258bd9)) ### core * Support Windows ([9af890c](9af890c)) * Support Windows ([3434c61](3434c61)) ### Features * **core:** Support Windows ([f0efca8](f0efca8)), closes [#665](#665) * **core:** Support Windows ([9787ba6](9787ba6)) * **utils:** refactor coverage config line parser into own util ([e03d453](e03d453)) ### BREAKING CHANGES * this should ideally get published as v5 * this should ideally get published as v5 * **core:** Support Windows, now that CodeClimate has released a Windows binary of the reporter – see codeclimate.com/changelog/7dd79ee1cf1af7141b2bd18b * **core:** Support Windows, now that CodeClimate has released a Windows binary of the reporter
|
🎉 This issue has been resolved in version 5.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
@bboyle I was finally able to land this in v5 of the action after a break from employment. Let me know if this works! |
|
sadly I don't have an easy way to test this now — my company shifted to a self-hosted gitlab. was looking forward to trying this out, I got a lot of great use from this codeclimate action while we were on github. thank you! I hope this windows release helps another dev |
Is your feature request related to a problem? Please describe.
This action currently checks the platform and blocks on windows.
CodeClimate say "Test Reporter tool now available for Windows" https://codeclimate.com/changelog/7dd79ee1cf1af7141b2bd18b
so maybe it's possible to easily support windows?
Describe the solution you'd like
I would like to run this action on windows.
Describe alternatives you've considered
Other codeclimate coverage reporter actions don't seem as full-featured (especially collecting multiple coverage reports from a monorepo).
Running the actions on linux caused other integration issues.
The cost of running my automated tests on linux is higher than on windows (linux minutes are cheaper on github, but the tests take so much longer to run that the net cost is higher).
Additional context
If this is something I can help with, let me know. I can see where the windows platform checks are but don't know if it's as simple as removing them, or if more is required. I'm not familiar with creating github actions.
The text was updated successfully, but these errors were encountered: