-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Pa11y 7, require Node 18, fix issues #149
Conversation
7f471e0
to
4a33294
Compare
…`package.engines.npm` as `10`
… it's more relevant; fix two inconsistencies in the app
8f5b461
to
e851970
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Superb, thank you so much @danyalaytekin 🙏
There's a few lint warnings in model/task.js
. All of them are about complexity though, and i think it's probably more important at this point to just get this merged and worry about decomplexifying those blocks later.
Aside from that, i just added suggestions with direct links to Docker and Act.
Co-authored-by: Hollie Kay <[email protected]>
Co-authored-by: Hollie Kay <[email protected]>
Co-authored-by: Hollie Kay <[email protected]>
…e shortlinks for consistency Co-Authored-By: Hollie Kay <[email protected]>
ceee5cb
to
d857fb1
Compare
Thanks @hollsk, I've committed those and added one more (added a list at the bottom of the PR description). I don't think the linters' warnings were introduced by this PR, including the nesting one since the previous version had nesting 3 as well, unless the rule doesn't apply to inline functions, but I agree about placating them at some point for the various codebases they're affecting. |
Oh yes, love opening up a codebase and finding ancient lint errors in it 😆 Looks perfect, thank you! |
This PR updates the service to use
pa11y@7
, updates the minimum version of Node.js required to18
, and makes several other changes to modernise the project.Changes
18
from12
pa11y@7
in place of6
hapi@21
in place of20
actions@setup-node@4
in place of3
request
ubuntu-latest
fromubuntu-20.04
make
withnpm
scriptsutil.promisify
to flatten some async coderequest
withfetch
throughoutenv
tomode
for clarityasync
syntax, replacingdone
syntaxnektos/act
to test locallyChanges during review process
act
act
is for locally testing GitHub Actionsact
; use shortlinks for consistencyThanks for the review and documentation fixes @hollsk