Relax bounds so compdata builds with GHC-shipped core libraries
#40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The aim seems to support GHC 9.2 - 9.8, so the lower bounds of the dependencies should allow to build with the libraries shipped with GHC 9.2: - `containers-0.6.5` - `mtl-2.2.2` - `transformers-0.5.6`
Further: - bump `actions/checkout` - use `haskell-actions` instead of the deprecated `haskell/actions` - use `plan.json` as cache key rather than the freeze file - use full version numbers of GHC and Cabal in cache key - single out building of dependencies in extra step
andreasabel
changed the title
compdata builds with GHC-shipped core libraries
|
ATTN: @pa-ba |
|
Thanks @andreasabel ! |
|
Welcome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue underlying
The current bounds on dependencies
containers,mtl, andtransformersare too strict as they do not allow building with the GHC-shipped versions of these libraries. This is a bit problematic for two reasons:compdata, other dependencies may have to be rebuild as the default versions of the ubiquitouscontainers,mtl, andtransformerscan't be usedThis PR relaxes the bounds so as
compdatais buildable with the pre-installed versions of the libraries of GHC 9.2 - 9.8.Also, there are revisions to the CI, mainly:
constraints: mtl installedetc to thecabal.project.localfilecabal build --dry-runThe changes in the PR can be published as a Hackage revision, no new version of
compdataneeded.Commits:
Successful run at: https://github.com/andreasabel/compdata/actions/runs/6588090303