Some tweaks to work with ghc 9.2.1 #37
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey yall, I needed a ghc 9.2.1 compatible version of compdata for a project and thought I'd share.
The majority of the issues that came up are due to changes in template haskell, which I fixed using template-haskell-compat-v0208 (but the functions used also wouldn't be too complicated to reimplement if introducing a new dependency isn't wanted)
The only bigger non-template-haskell-related issues were the ones that led to the changes in src/Data/Comp/Multi/HFoldable.hs and src/Data/Comp/Multi/Variables.hs - I'll be honest, I have no clue why those fixes work, which is why I've marked this as a draft, but am happy to learn and/or provide more details.
As to which other versions this is compatible with, I've never worked with travis ci before but fwiw it built & tested successfully manually with ghc 9.2.2, 9.2.1, 8.10.7, 8.10.2 and 8.8.1