bug: fix closing modal

p6te · Jan 2, 2024 · 0b8904d · 0b8904d
1 parent fd9684b
commit 0b8904d
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/src/components/UserSettings/index.tsx b/src/components/UserSettings/index.tsx
@@ -52,14 +52,15 @@ export default function UserSettings({ setIsLoading, onClose }: Props) {
     if (errors.username) {
       return;
     }
-    setIsLoading(true);
+
     const values = getValues();
 
     if (
       (imageURL !== "" ||
         values.username !== (loggedUser?.displayName as string)) &&
       !!loggedUser.displayName
     ) {
+      setIsLoading(true);
       try {
         const date = new Date().getTime();
         const storageRef = ref(
@@ -114,6 +115,8 @@ export default function UserSettings({ setIsLoading, onClose }: Props) {
         // TODO Send to error page
         alert(error.message);
       }
+    } else {
+      onClose();
     }
   };