Skip to content

Commit

Permalink
Don't try to test on GNUkFreeBSD or NetBSD as LibUV does not support
Browse files Browse the repository at this point in the history 
those platforms.
  • Loading branch information
@genio
genio committed Apr 10, 2019
1 parent ba73c73 commit 40cc094
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 0 deletions.
3 changes: 3 additions & 0 deletions .mm_awesome_header.pl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -14,3 +14,6 @@
die("OS unsupported\nWindows needs to be Win7 or higher.\n");
}
}
elsif ($^O eq 'gnukfreebsd' or $^O eq 'netbsd') {
die("OS unsupported\n");
}
2 changes: 2 additions & 0 deletions Changes
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ Revision history for {{$dist->name}}

{{$NEXT}}
- Update to the libuv v1.27.0 release
- Don't try to test on GNUkFreeBSD or NetBSD as the library isn't
supported there

1.008 2019-02-07
- Update to the libuv v1.25.0 release
Expand Down
3 changes: 3 additions & 0 deletions Makefile.PL
View file
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,9 @@ if ($^O eq 'MSWin32') {
die("OS unsupported\nWindows needs to be Win7 or higher.\n");
}
}
elsif ($^O eq 'gnukfreebsd' or $^O eq 'netbsd') {
die("OS unsupported\n");
}

my %WriteMakefileArgs = (
"ABSTRACT" => "Interface to the libuv library L<http://libuv.org>",
Expand Down

12 comments on commit 40cc094

@krytarowski
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will fix it for NetBSD!

@genio
Copy link
Collaborator Author

@genio genio commented on 40cc094 Apr 10, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@krytarowski I will gladly turn it back on for NetBSD if you can get support for it added to the libuv project

@genio
Copy link
Collaborator Author

@genio genio commented on 40cc094 Apr 10, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These failure reports may help see/fix the errors faster:

http://matrix.cpantesters.org/?dist=Alien-libuv%201.008;os=netbsd;reports=1

@krytarowski
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Soon I will upstream a patch to libuv.. testing.

@krytarowski
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at this matrix: NetBSD-6 isn't supported, 7.0 is oldstable and no point to patch libuv for it. 8.0 is minimal.

Could you please switch matrix to NetBSD-8.0?

Meanwhile I will submit fixup(s) to libuv for recent regressions.

@genio
Copy link
Collaborator Author

@genio genio commented on 40cc094 Apr 10, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't, unfortunately. The CPAN Testers Matrix is a community-driven testing platform that's great, but it doesn't allow module authors to pick and choose a specific version or versions or even OSes to hit a release for testing. Earlier versions of the module (pointing to slightly older minor releases of libuv) have some NetBSD-7.0 testers. http://matrix.cpantesters.org/?dist=Alien-libuv%201.007;os=netbsd;reports=1 for example.

I'd also be happy to amend my wholesale removal of support for NetBSD to just those older than version 8, if that makes the most sense. I mainly completely removed it because I haven't yet seen a pass on the matrix and I couldn't find it in libuv's supported platforms matrix: https://github.com/libuv/libuv/blob/v1.x/SUPPORTED_PLATFORMS.md

@krytarowski
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build fixup: libuv/libuv#2252

We are not listed in supported platforms mainly because we don't have CI machine in the project. I've prompted for one, but libuv (or nodejs?) admins couldn't find resources and the topic died.

There are downstream patches for at least NetBSD-7.0 in pkgsrc, 6.x has probably very few users.

I would unblock NetBSD unconditionally and really ask matrix people for upgrade.

@genio
Copy link
Collaborator Author

@genio genio commented on 40cc094 Apr 10, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to look into it and explain things. I"ll cut a release tonight that removes that block on NetBSD

@krytarowski
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are also 5 regressions in tests.

$ make check 2>&1|grep 'not ok'
not ok 21 - connect_unspecified
not ok 114 - getaddrinfo_fail
not ok 115 - getaddrinfo_fail_sync
not ok 186 - poll_oob
not ok 264 - tcp_oob

I will have a look into it independently. Most of them look like ipv6 specific.

@genio
Copy link
Collaborator Author

@genio genio commented on 40cc094 Apr 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@krytarowski This might be of some help. I'm about to bump libuv to 1.28.0 (latest release) and those tests will probably start showing up in 2-3 days.

libuv v1.27.0
http://matrix.cpantesters.org/?dist=Alien-libuv%201.010;os=netbsd;reports=1

@krytarowski
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've checked and there are patches in pkgsrc for NetBSD 6.x for libuv. I have no motivation to push them upstream myself as I don't use anything older than 8.x.

@krytarowski
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to help to upstream them so tests against oldoldstable releases (6.x) will work.

Please sign in to comment.