Add support for Bzlmod, Bazel 7/8, Ubuntu 24.04 (fixes #515, fixes #516, fixes #514) #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smolkaj
force-pushed
the
bzlmod2
branch
6 times, most recently
from
3291728 to
0db5b5c
Compare
smolkaj
changed the title
smolkaj
changed the title
smolkaj
force-pushed
the
bzlmod2
branch
2 times, most recently
from
caaddaa to
662e950
Compare
…, fixes #514). Signed-off-by: Steffen Smolka <[email protected]>
smolkaj
requested review from
jonathan-dilorenzo
and removed request for
jonathan-dilorenzo
smolkaj
changed the title
jonathan-dilorenzo
approved these changes
Dec 18, 2024
|
@chrispsommers let me know if you also want to take a look before we merge this. |
chrispsommers
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried manually that both
and
work. #521 extends our CI scripts to test Bazel 7/8 and Ubuntu 22.04/24.04 automatically.