-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specify read-write symmetry exception for backup replicas in P4Runtime Spec. #511
base: main
Are you sure you want to change the base?
Conversation
…tion for backup replicas. Signed-off-by: Matthew Lam <[email protected]>
51b3509
to
7d23c8a
Compare
We might want to postpone this until #510 is merged. |
Signed-off-by: Matthew Lam <[email protected]>
Generally LGTM. Can you rebased to HEAD so the CI check passes? (See #513 for why it didn't pass in your run.) |
Signed-off-by: Matthew Lam <[email protected]>
@smolkaj @chrispsommers I have rebased to HEAD and made the requested change from "hierarchy" -> "sequence". Please take a look |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Chris, Steffen, you can merge this before the conversion to AsciiDoc if you really want to, but I doubt it is urgent. If you do, please let Davide and I know so we can make the corresponding change in the AsciiDoc version.
I think there is no particular urgency, as long as we don't forget about it. |
As far as Davide and I are concerned, the Asciidoc version of the P4Runtime spec is done, subject to review and approval by others, i.e. by you and Chris Sommers, unless you can find another volunteer to review the PR: #510 For that PR, the ball is in your and Chris's court now, waiting for you. |
Thanks for the nudge! I totally forgot about that (shame on me). Definitely agreed that we should merge #510 first, then. I just left my review. |
@verios-google PTAL
cc: @smolkaj for visibility