Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify read-write symmetry exception for backup replicas in P4Runtime Spec. #511

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

matthewtlam
Copy link
Contributor

@matthewtlam matthewtlam commented Dec 9, 2024

@verios-google PTAL
cc: @smolkaj for visibility

@chrispsommers
Copy link
Collaborator

We might want to postpone this until #510 is merged.

Signed-off-by: Matthew Lam <[email protected]>
@smolkaj
Copy link
Member

smolkaj commented Dec 13, 2024

Generally LGTM.

Can you rebased to HEAD so the CI check passes? (See #513 for why it didn't pass in your run.)

@matthewtlam
Copy link
Contributor Author

@smolkaj @chrispsommers I have rebased to HEAD and made the requested change from "hierarchy" -> "sequence". Please take a look

Copy link
Contributor

@jafingerhut jafingerhut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Chris, Steffen, you can merge this before the conversion to AsciiDoc if you really want to, but I doubt it is urgent. If you do, please let Davide and I know so we can make the corresponding change in the AsciiDoc version.

docs/v1/P4Runtime-Spec.mdk Outdated Show resolved Hide resolved
@smolkaj
Copy link
Member

smolkaj commented Dec 18, 2024

I think there is no particular urgency, as long as we don't forget about it.
Is there a rough target date for completing the Ascii oc conversion date?

@jafingerhut
Copy link
Contributor

I think there is no particular urgency, as long as we don't forget about it. Is there a rough target date for completing the Ascii oc conversion date?

As far as Davide and I are concerned, the Asciidoc version of the P4Runtime spec is done, subject to review and approval by others, i.e. by you and Chris Sommers, unless you can find another volunteer to review the PR: #510

For that PR, the ball is in your and Chris's court now, waiting for you.

@smolkaj
Copy link
Member

smolkaj commented Dec 18, 2024

Thanks for the nudge! I totally forgot about that (shame on me).

Definitely agreed that we should merge #510 first, then. I just left my review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants