-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue 491 - update changelog for 1.4.0 changes #501
Conversation
Signed-off-by: chris <chris.sommers@keysight.com>
Signed-off-by: chris <chris.sommers@keysight.com>
Signed-off-by: chris <chris.sommers@keysight.com>
Signed-off-by: chris <chris.sommers@keysight.com>
47d326c
to
fdf1852
Compare
Signed-off-by: chris <chris.sommers@keysight.com>
@jafingerhut @smolkaj could you please take a look? I'm hoping to pave the way for a release before the 4 Workshop. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great to me, thanks!
@duskmoon314 For some reason, merging in this modest change to .mdk and .md files produced a codecheck failure in the rust generated code. DO you have any idea why this might have happened? Here's the failed job: https://github.com/p4lang/p4runtime/actions/runs/11004409981/job/30555272186 I experimentally ran |
Weirdly, running |
Thanks for responding so quickly and offering to investigate! |
I think I found out why. In the previous PR #500, I only pinned the Three days ago, I tried adding |
#502 is opened to solve the issue. Please review. I hope this is the last commit to solve this kind version issue. orz |
Reviewed all commits since v1.3.0 and ensured every change was mentioned in the change log. Added some structure to categorize the changes.