lib: Add P4::warningCount() and P4::infoCount() #5098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlstill
added
the
core
vlstill
force-pushed
the
vstill/warn-info-count
branch
from
996d3cd to
9e8d633
Compare
Signed-off-by: Vladimír Štill <[email protected]>
Signed-off-by: Vladimír Štill <[email protected]>
fruffy
approved these changes
Jan 14, 2025
test/gtest/diagnostics.cpp
Outdated
| @@ -69,51 +69,58 @@ TEST_F(Diagnostics, P4_16_Disable) { | |||
| @diagnostic("uninitialized_out_param", "disable") | |||
| )")); | |||
| EXPECT_TRUE(test); | |||
| EXPECT_EQ(0u, ::P4::diagnosticCount()); | |||
| EXPECT_EQ(0u, P4::diagnosticCount()); | |||
There was a problem hiding this comment.
Probably do not even need the P4:: qualifier here. Not sure what our general policy is but these functions are all available in the P4 namespace.
There was a problem hiding this comment.
Right. I guess I am used to working on a code where P4 is just one of the namespaces :-).
Co-authored-by: Fabian Ruffy <[email protected]> Signed-off-by: Vladimír Štill <[email protected]>
Signed-off-by: Vladimír Štill <[email protected]>
qobilidop
approved these changes
Jan 15, 2025
Signed-off-by: Vladimír Štill <[email protected]>
Signed-off-by: Vladimír Štill <[email protected]>
Signed-off-by: Vladimír Štill <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is
errorCountanddiagnosticCountbut nowarningCountand noinfoCount. This PR adds them.