Factor common base ExternCall for ExternMethod/ExternFunction #4898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisDodd
force-pushed
the
cdodd-methodInstance
branch
from
04f2bb5 to
ad5ef30
Compare
vlstill
previously approved these changes
Sep 4, 2024
fruffy
added
the
core
ChrisDodd
force-pushed
the
cdodd-methodInstance
branch
from
ad5ef30 to
6fbfff4
Compare
vlstill
dismissed
their stale review
Assuming the @EXIT part does not beling here, feel free to ping me once the PR is ready.
ChrisDodd
force-pushed
the
cdodd-methodInstance
branch
from
6fbfff4 to
7ccbee6
Compare
vlstill
approved these changes
Sep 16, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
ChrisDodd
force-pushed
the
cdodd-methodInstance
branch
from
7ccbee6 to
338b02a
Compare
Signed-off-by: Chris Dodd <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 17, 2024
Signed-off-by: Chris Dodd <[email protected]>
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
linuxrocks123
pushed a commit
to linuxrocks123/p4c
that referenced
this pull request
Sep 18, 2024
…#4898) Signed-off-by: Chris Dodd <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.