Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Documentation build workflow action from Doxygen v1.11.0 to v1.12.0 #4861

Merged
merged 3 commits into from
Aug 10, 2024

Conversation

AdarshRawat1
Copy link
Member

@AdarshRawat1 AdarshRawat1 commented Aug 10, 2024

Background

Doxygen v1.12.0 introduces a feature that allows GitHub-flavored comments, enabling us to hide Doxygen commands from GitHub previews using <!--! ... --> . This enhancement follows a feature request I submitted to address concerns about visible Doxygen commands. For more details, please see the linked request.

Changes:

  • Updated Doxygen workflow action from v1.11.0 to v1.12.0.
  • Updated dependencies accordingly to support the new Doxygen version.

Impact:

This update requires strict usage of Doxygen v1.12.0 for consistent output. The older versions do not support this feature, so upgrading is necessary to avoid confusion in GitHub Markdown previews, especially when merging README files using commands like \include{doc} "../lib/README.md" .

Next Step

  • Once upgraded, all Doxygen commands will be enclosed in the new comment style to prevent them from appearing in GitHub previews.

Tradeoff:

This upgrade introduces a potential tradeoff where all users will need to adopt Doxygen v1.12.0 to ensure consistent results. This has been discussed with the mentors and should not pose any issues.

@fruffy fruffy added the documentation Topics related to compiler documentation. label Aug 10, 2024
Copy link
Contributor

github-actions bot commented Aug 10, 2024

githubloading A preview of this PR is available at: Preview Link
📂 View the source code here: View Source Code
🔧 Commit used for deployment: a46323db3931fe6110a0c74a6ecff2ae42edeb3b

Note: Changes may take a few seconds to appear on GitHub Pages. Please refresh the page if you do not see the updates immediately.

@fruffy fruffy requested a review from jafingerhut August 10, 2024 17:45
Copy link
Contributor

@jafingerhut jafingerhut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not personally tested out the changes in instructions, but they look reasonable to me.

@jafingerhut jafingerhut added this pull request to the merge queue Aug 10, 2024
Merged via the queue into p4lang:main with commit 360d2a2 Aug 10, 2024
19 checks passed
AdarshRawat1 added a commit to AdarshRawat1/p4c that referenced this pull request Aug 13, 2024
Using the New Doxygen comment style in v1.12.0 i.e.
`<!-- ... -->`
For details - p4lang#4861

Signed-off-by: Adarsh <[email protected]>
AdarshRawat1 added a commit to AdarshRawat1/p4c that referenced this pull request Aug 16, 2024
Using the New Doxygen comment style in v1.12.0 i.e.
`<!-- ... -->`
For details - p4lang#4861

Signed-off-by: Adarsh <[email protected]>
github-merge-queue bot pushed a commit that referenced this pull request Aug 19, 2024
* Create Subsections of related topics

Signed-off-by: Adarsh <[email protected]>

* Remove Revision History

Signed-off-by: Adarsh <[email protected]>

* Exclude Subsections from generated Documentation

Signed-off-by: Adarsh <[email protected]>

* Remove: deprecated Section from generated docs

Signed-off-by: Adarsh <[email protected]>

* Disable Todo list

Signed-off-by: Adarsh <[email protected]>

* Docs : Hide Namespace and Classes section from output

Signed-off-by: Adarsh <[email protected]>

* Merge P4C Overview with P4C root README

Signed-off-by: Adarsh <[email protected]>

* Minor Fix : missing "`" in directory structure

Signed-off-by: Adarsh <[email protected]>

* Remove Revision History

Signed-off-by: Adarsh <[email protected]>

* Merge P4C Overview with P4C root README

Signed-off-by: Adarsh <[email protected]>

* Disable Auto Link support for classes/namespaces

Signed-off-by: Adarsh <[email protected]>

* Merge "Common P4C Utility Functions" as a subsection of "P4C" Page

Signed-off-by: Adarsh <[email protected]>

* Convert file descriptions to Markdown table format in BMv2 "pna_nic" Backend

Signed-off-by: Adarsh <[email protected]>

* Remove Revision History

Signed-off-by: Adarsh <[email protected]>

* Merge P4C Overview with P4C root README

Signed-off-by: Adarsh <[email protected]>

* Remove Revision History

Signed-off-by: Adarsh <[email protected]>

* Merge P4C Overview with P4C root README

Signed-off-by: Adarsh <[email protected]>

* Content for P4test Backend

Signed-off-by: Adarsh <[email protected]>

* Refactor : Organize `portable_common` directory file descriptions

Organize `portable_common` directory file descriptions into a table format
Signed-off-by: Adarsh <[email protected]>

* Hide Doxygen Commands from GitHub Markdown render

Using the New Doxygen comment style in v1.12.0 i.e.
`<!-- ... -->`
For details - #4861

Signed-off-by: Adarsh <[email protected]>

* Create Subsections of related topics

Signed-off-by: Adarsh <[email protected]>

* Docs : Hide Namespace and Classes section from output

Signed-off-by: Adarsh <[email protected]>

* Merge P4C Overview with P4C root README

Signed-off-by: Adarsh <[email protected]>

* Remove Revision History

Signed-off-by: Adarsh <[email protected]>

* Merge P4C Overview with P4C root README

Signed-off-by: Adarsh <[email protected]>

* Content for P4test Backend

Signed-off-by: Adarsh <[email protected]>

* Fix : removed extra Command

Signed-off-by: Adarsh <[email protected]>

* Organize `IR` Classes descriptions into a table format

Signed-off-by: Adarsh <[email protected]>

* chore: Add TOC to content-rich pages

Signed-off-by: Adarsh <[email protected]>

* Remove TOC from Changelogs

Signed-off-by: Adarsh <[email protected]>

* Exclude GitHub markdown TOC from Doxygen output

Signed-off-by: Adarsh <[email protected]>

* Highlight sample backends in P4C with a dedicated heading

Signed-off-by: Adarsh <[email protected]>

* Merged: BMv2 "pna_nic" Backend into Behavioral Model Backend

Signed-off-by: Adarsh <[email protected]>

* Merge P4C IR Classes into IR Page

Signed-off-by: Adarsh <[email protected]>

* Change the top of tree view from "P4C" -> "P4 Compiler Documentation (P4C)"

Signed-off-by: Adarsh <[email protected]>

* Change root page heading "P4C" -> "Getting Started"

Signed-off-by: Adarsh <[email protected]>

* Move changelogs to the end of Side bar

Signed-off-by: Adarsh <[email protected]>

* Improve Getting started page heading

Signed-off-by: Adarsh <[email protected]>

* Merge "portable_common" section under "bmv2"

Signed-off-by: Adarsh <[email protected]>

* Minor formatting Fixes

Signed-off-by: Adarsh <[email protected]>

* Minor command fix

Signed-off-by: Adarsh <[email protected]>

* Fix: Broken Table structure in Doxygen output

Signed-off-by: Adarsh <[email protected]>

* Refactor : Page headings

Signed-off-by: Adarsh <[email protected]>

* Refactor : Ordering of backends

Signed-off-by: Adarsh <[email protected]>

* Enable Nice URL for generated docs

Current default doxygen URL config Output-
https://p4lang.github.io/p4c/md__2home_2runner_2work_2p4c_2p4c_2backends_2dpdk_2_r_e_a_d_m_e.html

Updated -
https://p4lang.github.io/p4c/dpdk_backend.html

Signed-off-by: Adarsh <[email protected]>

* Doc: Add inclusion notes to Documented Markdown files

- Added comments to indicate whether each README is included as a standalone page, a subsection, or not included in the P4 compiler documentation.
- Provided specific links to relevant sections or pages within the documentation.

Signed-off-by: Adarsh <[email protected]>

* Docs: Add remaining documentation inclusion notes

Signed-off-by: Adarsh <[email protected]>

* Add GitHub profile links for Core developers of p4tools

Compatible with GitHub and Doxygen

Signed-off-by: Adarsh <[email protected]>

* Fix: formatting of inclusion note

Signed-off-by: Adarsh <[email protected]>

* Docs: Side bar grouping of backends

Signed-off-by: Adarsh <[email protected]>

* Add Introduction for Frontend and Midend

Signed-off-by: Adarsh <[email protected]>

* Update lib/README.md

Signed-off-by: Adarsh <[email protected]>

Co-authored-by: Fabian Ruffy <[email protected]>
Signed-off-by: Adarsh Rawat <[email protected]>

* Revert: Changes that are migrated to PR #4876

Signed-off-by: Adarsh <[email protected]>

---------

Signed-off-by: Adarsh <[email protected]>
Signed-off-by: Adarsh Rawat <[email protected]>
Co-authored-by: Fabian Ruffy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Topics related to compiler documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants