-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set the initial default action for tables when generating a P4Info. #4773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fruffy
force-pushed
the
fruffy/default_entry
branch
from
July 2, 2024 16:32
1881059
to
4f72065
Compare
jafingerhut
reviewed
Jul 3, 2024
fruffy
force-pushed
the
fruffy/default_entry
branch
2 times, most recently
from
July 9, 2024 13:50
f854d88
to
bb38227
Compare
fruffy
force-pushed
the
fruffy/default_entry
branch
3 times, most recently
from
August 11, 2024 09:33
5b62bab
to
42984b1
Compare
fruffy
changed the title
Set the initial default action ID for tables when generating a P4Info.
Set the initial default action for tables when generating a P4Info.
Aug 11, 2024
fruffy
force-pushed
the
fruffy/default_entry
branch
from
August 11, 2024 10:05
42984b1
to
2871075
Compare
jafingerhut
reviewed
Aug 11, 2024
fruffy
force-pushed
the
fruffy/default_entry
branch
from
August 15, 2024 09:32
2871075
to
939b1ca
Compare
jafingerhut
approved these changes
Aug 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
fruffy
force-pushed
the
fruffy/default_entry
branch
from
August 18, 2024 15:29
939b1ca
to
c5d6a4e
Compare
Signed-off-by: fruffy <[email protected]>
Signed-off-by: fruffy <[email protected]>
fruffy
force-pushed
the
fruffy/default_entry
branch
from
August 19, 2024 07:30
c5d6a4e
to
faaf577
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corresponding P4Runtime PR: p4lang/p4runtime#486
Adds information about the default action of a table and the arguments it is invoked with to the generated P4Info file.
This change also required some small additions to the
bytestrings
utility file. MovedgetTypeWidth
to the file and also added a new helper for generalIR::Expression
inputs.Fixes #4662.