Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the initial default action for tables when generating a P4Info. #4773

Merged
merged 2 commits into from
Aug 26, 2024

Conversation

fruffy
Copy link
Collaborator

@fruffy fruffy commented Jul 1, 2024

Corresponding P4Runtime PR: p4lang/p4runtime#486

Adds information about the default action of a table and the arguments it is invoked with to the generated P4Info file.

This change also required some small additions to the bytestrings utility file. Moved getTypeWidth to the file and also added a new helper for general IR::Expression inputs.

Fixes #4662.

@fruffy fruffy added the control-plane Topics related to the control-plane or P4Runtime. label Jul 1, 2024
@fruffy fruffy force-pushed the fruffy/default_entry branch from 1881059 to 4f72065 Compare July 2, 2024 16:32
@fruffy fruffy force-pushed the fruffy/default_entry branch 2 times, most recently from f854d88 to bb38227 Compare July 9, 2024 13:50
@fruffy fruffy force-pushed the fruffy/default_entry branch 3 times, most recently from 5b62bab to 42984b1 Compare August 11, 2024 09:33
@fruffy fruffy changed the title Set the initial default action ID for tables when generating a P4Info. Set the initial default action for tables when generating a P4Info. Aug 11, 2024
@fruffy fruffy force-pushed the fruffy/default_entry branch from 42984b1 to 2871075 Compare August 11, 2024 10:05
@fruffy fruffy force-pushed the fruffy/default_entry branch from 2871075 to 939b1ca Compare August 15, 2024 09:32
Copy link
Contributor

@jafingerhut jafingerhut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fruffy fruffy force-pushed the fruffy/default_entry branch from 939b1ca to c5d6a4e Compare August 18, 2024 15:29
@fruffy fruffy force-pushed the fruffy/default_entry branch from c5d6a4e to faaf577 Compare August 19, 2024 07:30
@fruffy fruffy marked this pull request as ready for review August 19, 2024 09:06
@fruffy fruffy requested review from antoninbas and smolkaj August 19, 2024 09:09
@fruffy fruffy added this pull request to the merge queue Aug 26, 2024
Merged via the queue into main with commit 8beb35c Aug 26, 2024
19 checks passed
@fruffy fruffy deleted the fruffy/default_entry branch August 26, 2024 18:13
hanw pushed a commit that referenced this pull request Oct 6, 2024
hanw pushed a commit that referenced this pull request Oct 8, 2024
hanw pushed a commit that referenced this pull request Oct 9, 2024
grg pushed a commit that referenced this pull request Oct 9, 2024
hanw pushed a commit that referenced this pull request Oct 11, 2024
grg added a commit that referenced this pull request Oct 15, 2024
hanw pushed a commit that referenced this pull request Oct 15, 2024
hanw pushed a commit that referenced this pull request Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
control-plane Topics related to the control-plane or P4Runtime.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Emit the initial default action of a table in the P4Info file.
2 participants