-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix : Compatibility issues with Doxygen version in runner and configuration #4732
Conversation
This reverts commit 10abeb8.
.github/workflows/deploy-docs.yml
Outdated
run: sudo apt-get install doxygen graphviz -y | ||
shell: bash | ||
- name: Install Custom Doxygen Version | ||
uses: AdarshRawat1/[email protected] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is your own action? Neat. However, for maintenance reasons it might be easier to just inline this particular installation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is your own action? Neat.
Yes ! Thanks
However, for maintenance reasons it might be easier to just inline this particular installation.
Sure, I'll do that !!
However this action is responsible only for installating particular version of doxygen being passed, and it would be cleaner this way. (We can simply update the version being passed.)
That is the reason I thought it would be better to have a custom action.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As there isn't much that we'll have to maintain here other than the version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The main reason for inlining is that we maintain the installation directly here in P4C whereas with the other approach we have to depend on an external action we do not necessarily own.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure thing !
Head branch was pushed to by a user without write access
Is there any difference in information published to P4.org public pages, or any p4lang projects, as a result of these changes? If so, what links could I look at to see the results? Or perhaps these changes require running Doxygen on one's local system? |
https://p4lang.github.io/p4c/pages.html The page is still work in progress. |
Initially, there was this requirement of running the Doxygen locally. |
Impact
Fix the output generated by deploy workflow