Generalize get in map utils #4483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fruffy
added
the
core
vlstill
reviewed
Feb 29, 2024
| // Given a map and a key, return a optional<V> if the key exists and None if the | ||
| // key does not exist in the map. | ||
| template <class Map, typename Key = typename Map::key_type> | ||
| std::optional<typename Map::mapped_type> get_optional(const Map &m, const Key &key) { |
There was a problem hiding this comment.
getopt would be more consistent with getref. I'm not sure myself which one is better, we could go with the more explicit name you have chosen.
There was a problem hiding this comment.
I though about this. But getopt in a global scope is already taken by...getopt :) https://man7.org/linux/man-pages/man3/getopt.3.html So, less name clashes. It has different signature, but since it's a C function I'm afraid of macroses. We can give getopt a try and see how it will go.
There was a problem hiding this comment.
I see. Now I'm slightly leaning towards get_optional to avoid possible confusion. The error messages could get weird with getopt too.
vlstill
reviewed
Feb 29, 2024
vlstill
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.