Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[P4Testgen] Fix another segmentation fault when using the coverable nodes scanner. #4203

Merged
merged 1 commit into from
Oct 23, 2023
Merged

[P4Testgen] Fix another segmentation fault when using the coverable nodes scanner. #4203

merged 1 commit into from
Oct 23, 2023

Conversation

fruffy
Copy link
Collaborator

@fruffy fruffy commented Oct 22, 2023

Avoid passing a nullptr to the CoverableNodesScanner.

@fruffy fruffy added the p4tools Topics related to the P4Tools back end label Oct 22, 2023
@fruffy fruffy changed the title Fix another segmentation fault when using the coverable nodes scanner. [P4Testgen] Fix another segmentation fault when using the coverable nodes scanner. Oct 22, 2023
@fruffy fruffy requested review from pkotikal and jnfoster October 23, 2023 12:51
jnfoster
jnfoster approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@jnfoster jnfoster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fruffy fruffy merged commit 0aa2797 into main Oct 23, 2023
13 checks passed
@fruffy fruffy deleted the fruffy/fix_switchstatement_crash branch October 23, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnfoster jnfoster jnfoster approved these changes

@pkotikal pkotikal Awaiting requested review from pkotikal

Assignees
No one assigned
Labels
p4tools Topics related to the P4Tools back end
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fruffy @jnfoster