ParserUnroll: fix seg. fault for uninitialized variables inside header stack indexes #4200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for fixing this! |
jafingerhut
reviewed
Oct 18, 2023
mihaibudiu
reviewed
Oct 18, 2023
You're welcome ;). It was nice to remember this code. |
|
Are the files in the testdata/p4_16_samples_output/parser-unroll directory used for anything during CI testing? If yes, what for? |
These files are used to store results for p4test when it runs with the |
fruffy
approved these changes
Oct 20, 2023
fruffy
reviewed
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes fix the segmentation fault inside ParserUnroll for uninitialized variables that are used as a header stack index. In this case, ParserUnroll generates a warning message and leaves the program as is.