Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dpdk Backend :Fix header stack assignment in p4c-dpdk #4100

Merged
merged 1 commit into from
Aug 9, 2023

Conversation

usha1830
Copy link
Contributor

@usha1830 usha1830 commented Aug 8, 2023

Fixes #4087

@jafingerhut
Copy link
Contributor

What do you think of waiting on merging this until #4072 has been merged in, and then we can add a PTF test for this PR that provides additional test coverage that after these p4c-dpdk changes, the P4-DPDK packet processing behavior is correct?

@fruffy fruffy added the dpdk Topics related to the DPDK back end label Aug 8, 2023
Copy link
Contributor

@jafingerhut jafingerhut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for now. I have created separate issue to track the creation of a PTF test with packets to exercise the new P4 program added with this PR, for better test coverage of the fix.

@jafingerhut jafingerhut merged commit 624c6be into p4lang:main Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dpdk Topics related to the DPDK back end
Projects
None yet
Development

Successfully merging this pull request may close these issues.

p4c-dpdk back end gives error for assignment between elements of a header stack
4 participants