Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[P4Testgen] Move P4Testgen solver class to lib folder #4091

Merged
merged 1 commit into from
Sep 13, 2023
Merged

[P4Testgen] Move P4Testgen solver class to lib folder #4091

merged 1 commit into from
Sep 13, 2023

Conversation

fruffy
Copy link
Collaborator

@fruffy fruffy commented Aug 2, 2023

Fixes #3519.

@fruffy fruffy force-pushed the fruffy/solver_as_lib branch 2 times, most recently from f8a87e2 to 7681884 Compare August 2, 2023 19:21
@jafingerhut jafingerhut added the p4tools Topics related to the P4Tools back end label Aug 7, 2023
@fruffy fruffy changed the title Move P4Testgen solver class to lib folder [P4Testgen] Move P4Testgen solver class to lib folder Aug 11, 2023
@fruffy fruffy force-pushed the fruffy/solver_as_lib branch from 7681884 to a32f7fe Compare August 26, 2023 18:31
@fruffy fruffy closed this Sep 13, 2023
@fruffy fruffy reopened this Sep 13, 2023
@fruffy fruffy requested a review from jafingerhut September 13, 2023 15:00
jafingerhut
jafingerhut approved these changes Sep 13, 2023
View reviewed changes
Copy link
Contributor

@jafingerhut jafingerhut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but note that I am not involved much in developing p4c code, so perhaps not the strongest approval you can get, as compared to someone else actually working on p4testgen implementation.

@fruffy
Copy link
Collaborator Author

fruffy commented Sep 13, 2023

Thanks!

@fruffy fruffy merged commit 66eefde into main Sep 13, 2023
@fruffy fruffy deleted the fruffy/solver_as_lib branch September 13, 2023 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jafingerhut jafingerhut jafingerhut approved these changes

@pkotikal pkotikal Awaiting requested review from pkotikal

@jnfoster jnfoster Awaiting requested review from jnfoster

Assignees
No one assigned
Labels
p4tools Topics related to the P4Tools back end
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move the solver.cpp class of P4Testgen into lib
2 participants
@fruffy @jafingerhut