Also suppress no-gnu-zero-variadic-macro-arguments warnings for MacOs. #4023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fruffy
force-pushed
the
fruffy/macos_warning
branch
8 times, most recently
from
4c91863 to
0eaf799
Compare
fruffy
force-pushed
the
fruffy/macos_warning
branch
from
0eaf799 to
8c341d7
Compare
jafingerhut
approved these changes
Jun 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get rid of the excessive printing of warnings for MacOS. Also add notes for some other spurious warnings. Unfortunately, we can not get rid of the Bison .ypp warning until we deprecate Ubuntu 18.04.
This PR also coincidentally fixes a breaking change introduced by Protobuf in version 22.x. Protobuf now also pulls in Abseil, which we currently do not require and thus we run into undefined symbol errors. So far, this issue only occurs with MacOS builds, but may become a problem for all other builds in the future.
Protobuf is a really problematic, huge dependency, I wish we could get rid of it.