Remove boost::filesystem from P4Testgen. #3944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkotikal
reviewed
Mar 27, 2023
| @@ -77,7 +77,7 @@ const BMv2_V1ModelProgramInfo *BMv2_V1ModelTestgenTarget::initProgram_impl( | |||
|
|
|||
| Bmv2TestBackend *BMv2_V1ModelTestgenTarget::getTestBackend_impl( | |||
| const ProgramInfo &programInfo, SymbolicExecutor &symbex, | |||
| const boost::filesystem::path &testPath, boost::optional<uint32_t> seed) const { | |||
| const std::filesystem::path &testPath, boost::optional<uint32_t> seed) const { | |||
There was a problem hiding this comment.
Can we change boost::optional to std::optional too?
There was a problem hiding this comment.
Yes, the corresponding PR can be found here: #3942
There was a problem hiding this comment.
I will also try to do this for std::variant, but that is a bit more tricky.
There was a problem hiding this comment.
got it, is there a reason we are moving away from boost - is it to avoid extra dependencies?
There was a problem hiding this comment.
Yes, boost adds compile time and binary size overhead. It is also one of the major sources for build issues (next to protobuf). So I am trying to at least fix some low-hanging fruits.
pkotikal
approved these changes
Mar 27, 2023
fruffy
force-pushed
the
fruffy/remove_boost_fs
branch
from
971c3be to
e90e792
Compare
fruffy
force-pushed
the
fruffy/remove_boost_fs
branch
from
e90e792 to
80d1b8e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.