Make {#} a single token #3835
Merged
Make {#} a single token #3835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that my approval is for the grammar and lexer parts, not the rest of the C++ implementation, which I am not qualified to review at this time. Question: Is it overkill to add a test case with white space in the middle to verify that it gives an error, e.g. "h1 = { # };" ? |
added 2 commits
January 11, 2023 11:43
Signed-off-by: Mihai Budiu <[email protected]>
Signed-off-by: Mihai Budiu <[email protected]>
|
Added a negative test. |
|
Thanks for the negative test case. My approval still stands. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mihai Budiu [email protected]
As discussed during the January 2023 LDWG meeting.
p4lang/p4-spec#1184 will have to be updated.
This PR also refactors the IR to make it easier to add invalid header unions in a future PR.