Fix clang_format mismatch. #3831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fruffy
force-pushed
the
fruffy/clang_format_fix
branch
from
0a89b57 to
0e7aec8
Compare
fruffy
force-pushed
the
fruffy/clang_format_fix
branch
from
0e7aec8 to
537ada7
Compare
|
@mbudiu-vmw There are unrelated PRs failing because this check is missing. I also fixed all Python dependencies. Could you give this a review? |
|
What should we do about #3810? |
mihaibudiu
approved these changes
Jan 12, 2023
|
Thanks! Regarding #3810 the clang-format file is not broken, it's just a different pointer alignment. I am indifferent about the style as long as it is consistent. |
|
We always used the other pointer style. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fix pip package versions using a requirements.txt file.