Try to merge copyHeaders into copyStructures. #3739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fruffy
requested review from
pkotikal,
vhavel,
jnfoster and
mihaibudiu
as code owners
pkotikal
approved these changes
Nov 29, 2022
mihaibudiu
approved these changes
Nov 29, 2022
midend/copyStructures.cpp
Outdated
| return statement; | ||
| const auto& srcInfo = statement->srcInfo; | ||
| auto* retval = new IR::IndexedVector<IR::StatOrDecl>(); | ||
| if (const auto* list = statement->right->to<IR::ListExpression>()) { |
There was a problem hiding this comment.
I think this cannot happen anymore, these should have been replaced with StructExpressions.
This is a leftover from when we didn't have StructExpressions.
There was a problem hiding this comment.
So where in the compiler do ListExpressions still exist? They are useful in that StructExpressions require NamedExpressions, a specific type of Expression.
There was a problem hiding this comment.
They may still exist before the type checker replaces them with struct expressions. They show up as initializers for various data structures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on #3726.