Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Off by one warning error in constant-folding for large shifts #3715

Merged
merged 2 commits into from
Nov 23, 2022

Conversation

mihaibudiu
Copy link
Contributor

Signed-off-by: Mihai Budiu [email protected]
Fixes #3289

@mihaibudiu mihaibudiu requested a review from fruffy November 21, 2022 20:11
Signed-off-by: Mihai Budiu <[email protected]>
@mihaibudiu mihaibudiu requested review from jafingerhut and rst0git and removed request for fruffy November 21, 2022 21:06
Copy link
Member

@rst0git rst0git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mihaibudiu mihaibudiu merged commit 4e5187a into p4lang:main Nov 23, 2022
@mihaibudiu mihaibudiu deleted the issue3289 branch November 23, 2022 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

warning for unsigned fixed width shift left is twice
2 participants