PSA/eBPF: use slice-by-8 algorithm for CRC-32 #3688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihaibudiu
approved these changes
Nov 11, 2022
|
A few PTF tests are failing, @majchwo and I will fix them soon. |
|
@mbudiu-vmw @majchwo done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously CRC-32 was calculated using bitwise operations (bit-by-bit). This PR implements more efficient algorithm for CRC-32 using slice-by-8 algorithm. The performance gain depends on the length of an input data. For example, with 40 bytes of input data we observed about 35% reduction of CPU cycles per packet.
This work has been done in cooperation with @osinstom & @tatry.