Dpdk Backend: Allow non-constant arguments to mirror_packet extern #3473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ameter used as mirror_packet argument to metadata
|
Mac OS checks are cancelled for unknown reason!! |
mihaibudiu
approved these changes
Aug 3, 2022
@mbudiu-vmw Thanks for the review!. Now the Mac OS checks are passing. Could you please merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the checks for allowing only constant arguments to mirror_packet extern.
The "mirror" instruction in DPDK assembly expects both the arguments in metadata. Hence, move instruction is inserted to move the argument to metadata if not already present in metadata