-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Javascript implementation of mesh schema #86
Comments
Okay, looks like opportunistic compression is failing. Or at least providing results that Python can't read. Time to investigate. |
This isn't a failure of opportunistic compression. It's a failure of encoding somewhere down the line. When Javascript sends its message over a socket, it comes out as Python recognizes this as invalid (which it is), so it disconnects. Javascript also recognizes this as invalid. So the question becomes, when is the invalid information getting in? Is it on message construction? Is it on message transmission? |
It's not just a matter of a packet size descriptor being wrong. Changing the message to get correct packet sizes doesn't seem to fix the problem. Of course, I could be modifying it incorrectly, which would also yield the checksum failure I'm seeing. |
The string it was supposed to generate was:
There were two changes made to the string. First, two characters were left off the end. That's the "]]". Second, the total length field was mutated by this. However, the checksum was not changed. This is weird, since it's based on contents that were changed. It would appear that this error is just isolated to the packet sizing methods. For instance, a message with a length of 255 is self-reporting as being 239 characters. Or 253 if you put it through a Buffer first. It's very odd, and needs serious investigation. |
This is fixed in 102f44c |
Oh, and I need to remove all these debug prints at some point. This is ridiculous. |
Kay. Debug prints removed except where it's obvious to have them. Connection cleaning added. So there's a basically-full implementation in less than 72 hours (given an existent parser). Now I just need to figure out how to get testing set up, and see if the compression support works properly. |
Enabled again. Seems to work. |
I'm testing this against the python version.
Currently the implementation works as a passive receiver. I am currently working in ES6, with the intent to later translate into ES5 for browser compatibility. There are two open bugs:
The text was updated successfully, but these errors were encountered: