Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore generator tests #16

Merged
merged 6 commits into from
Oct 3, 2024
Merged

Restore generator tests #16

merged 6 commits into from
Oct 3, 2024

Conversation

sneakers-the-rat
Copy link
Contributor

@sneakers-the-rat sneakers-the-rat commented Oct 1, 2024 •
edited
Loading

Generator tests are currently all skipped.

Most of that behavior has been moved upstream to the linkml generator. Need to remove outdated tests and add tests for stuff we've added since then.

Not going to to test behavior of included hdmf modules (that's on test_includes), or that the lifecycle methods are working

@coveralls
Copy link

coveralls commented Oct 1, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11119755156

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.002%) to 90.377%
Totals Coverage Status
Change from base Build 11118854255: -0.002%
Covered Lines: 2418
Relevant Lines: 2688
💛 - Coveralls

@sneakers-the-rat sneakers-the-rat marked this pull request as ready for review October 3, 2024 03:40
@sneakers-the-rat sneakers-the-rat merged commit 77a8529 into main Oct 3, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sneakers-the-rat @coveralls