Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

virtual: Auto-generate boilerplate functions from JSON #537

Merged
merged 1 commit into from
Aug 7, 2023

Conversation

ueno
Copy link
Member

@ueno ueno commented Aug 2, 2023

To avoid a lot of code repetitions in p11-kit/virtual.c, this introduces a mechanism to generate those from pkcs11.h, through a JSON based intermediate data format.

Fixes: #494

@ueno ueno force-pushed the wip/dueno/codegen branch 5 times, most recently from 3c34af6 to 9bfbc48 Compare August 2, 2023 05:30
@coveralls
Copy link

coveralls commented Aug 2, 2023

Coverage Status

coverage: 68.63% (-0.9%) from 69.536% when pulling e977e1e on ueno:wip/dueno/codegen into f88faf9 on p11-glue:master.

@ueno ueno force-pushed the wip/dueno/codegen branch 12 times, most recently from 0653e31 to 1033ac1 Compare August 7, 2023 05:13
To avoid a lot of code repetitions in p11-kit/virtual.c, this
introduces a mechanism to generate those from pkcs11.h, through a JSON
based intermediate data format.

Signed-off-by: Daiki Ueno <[email protected]>
@ueno ueno force-pushed the wip/dueno/codegen branch from 1033ac1 to e977e1e Compare August 7, 2023 05:41
ueno added a commit to ueno/oss-fuzz that referenced this pull request Aug 7, 2023
p11-kit build infrastructure will require Python for code generation:
p11-glue/p11-kit#537

Signed-off-by: Daiki Ueno <[email protected]>
DavidKorczynski pushed a commit to google/oss-fuzz that referenced this pull request Aug 7, 2023
p11-kit build infrastructure will require Python for code generation:
p11-glue/p11-kit#537

Signed-off-by: Daiki Ueno <[email protected]>
@ueno ueno requested a review from ZoltanFridrich August 7, 2023 12:01
Copy link
Contributor

@ZoltanFridrich ZoltanFridrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@ueno ueno merged commit 91bec95 into p11-glue:master Aug 7, 2023
@ZoltanFridrich ZoltanFridrich added this to the 0.25.1 milestone Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

More use of code generation in p11-kit/virtual.c
3 participants