Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add command to add profiles to a token #506

Merged
merged 3 commits into from
May 23, 2023
Merged

Add command to add profiles to a token #506

merged 3 commits into from
May 23, 2023

Conversation

ZoltanFridrich
Copy link
Contributor

Adds the ability to add profile objects to given PKCS#11 token.

$ p11-kit add-profile --profile public-certificates-token 'pkcs11:token=MyToken'

@ZoltanFridrich ZoltanFridrich self-assigned this May 9, 2023
@ZoltanFridrich ZoltanFridrich force-pushed the zfridric_devel2 branch 3 times, most recently from 43c2197 to 077b2f5 Compare May 9, 2023 15:06
@coveralls
Copy link

coveralls commented May 9, 2023 •
edited
Loading

Coverage Status

Coverage: 70.096% (-0.2%) from 70.3% when pulling 4a9dac8 on ZoltanFridrich:zfridric_devel2 into 6f6c04d on p11-glue:master.

ueno
ueno reviewed May 10, 2023
View reviewed changes
p11-kit/add-profile.c Outdated Show resolved Hide resolved
@ZoltanFridrich ZoltanFridrich force-pushed the zfridric_devel2 branch 2 times, most recently from ed3906e to b3eadfd Compare May 23, 2023 08:56
@ZoltanFridrich
Test p11_constant_profiles
4e3deee 
Signed-off-by: Zoltan Fridrich <[email protected]>
@ZoltanFridrich ZoltanFridrich requested a review from ueno May 23, 2023 10:48
ueno
ueno approved these changes May 23, 2023
View reviewed changes
Copy link
Member

@ueno ueno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Could you fix the authorship of 7146901 which has myself as Author for some reason?

@ZoltanFridrich ZoltanFridrich merged commit 2fbe188 into p11-glue:master May 23, 2023
@ZoltanFridrich ZoltanFridrich added this to the 0.25.0 milestone Jun 28, 2023
@brisingraerowing brisingraerowing mentioned this pull request Jul 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ueno ueno ueno approved these changes

Assignees

@ZoltanFridrich ZoltanFridrich

Labels
enhancement
Projects
None yet
Milestone
0.25.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ZoltanFridrich @coveralls @ueno