server: Fix umask setting when --group is specified #478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p11-kit server previously set umask(066) unconditionally before chown and that resulted in removing group read/write bits, even if --group is specified. This fixes the logic to respect --group and also allows it to be specified without --user. Originally reported in: https://lists.freedesktop.org/archives/p11-glue/2023-January/000725.html Signed-off-by: Daiki Ueno <[email protected]>
ueno
force-pushed
the
wip/dueno/server-umask
branch
from
979e48b to
d6518ee
Compare
|
I'm filing this on behalf of the original submitter, and the change looks good; merging without approval. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
p11-kit server previously set umask(066) unconditionally before chown and that resulted in removing group read/write bits, even if --group is specified. This fixes the logic to respect --group and also allows it to be specified without --user.
Originally reported in:
https://lists.freedesktop.org/archives/p11-glue/2023-January/000725.html