Test improvements (from #374) #443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was introduced as part of c01b59e (Check exhaustion of fixed closures ) which looks like it did not test the original issue.
Signed-off-by: Jakub Jelen <[email protected]>
Jakuje
force-pushed
the
test-improvements
branch
from
51ba846 to
672670d
Compare
ueno
approved these changes
Feb 28, 2023
|
Addressed the issues as fixup commits so far for easier review. Can squash when ready. |
|
LGTM! |
This increase test coverage and captures more corner cases of parameters and return values handling. Namely: * NULL mechanism cancels operation, but it was considered here as bad arguments * Some queries for buffer sizes were incorrectly finalizing the operations * Changed the internal operation identification to use CK_FLAGS as suggested by specs * Verify operation was not correcly finalized when the signature was not valid in mock * The log and rpc modules were not handling the NULL mech correctly
The proto_read_byte_array() is used in IN_BYTE_ARRAY. Its client counterpart is using p11_rpc_message_write_byte_array(), which ads uint32 item with the array size after 0 byte, but this was never read here causing message corruption errors.
Jakuje
force-pushed
the
test-improvements
branch
from
c0ea8ba to
79a43d2
Compare
|
autosquashed the previous commits |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is bunch of assorted test improvements to improve code coverage and fix minor issues noticed while working on that.
This was initially submitted as part of #374 but splitting it now to make it simpler to review and merge.