Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.github/workflows/test.yaml: Enable CI on macOS #441

Merged
merged 1 commit into from
Nov 9, 2022
Merged

.github/workflows/test.yaml: Enable CI on macOS #441

merged 1 commit into from
Nov 9, 2022

Conversation

ueno
Copy link
Member

@ueno ueno commented Oct 30, 2022

Signed-off-by: Daiki Ueno [email protected]

@coveralls
Copy link

coveralls commented Oct 30, 2022 •
edited
Loading

Coverage Status

Coverage remained the same at 71.336% when pulling 864dbfb on ueno:wip/dueno/ci-macos into 8c917c0 on p11-glue:master.

@ueno ueno force-pushed the wip/dueno/ci-macos branch 8 times, most recently from 74678c3 to 864dbfb Compare October 30, 2022 23:33
@ueno ueno marked this pull request as ready for review October 30, 2022 23:37
@ueno ueno mentioned this pull request Oct 30, 2022
Closed
@ueno ueno requested a review from ZoltanFridrich October 31, 2022 22:42
ZoltanFridrich
ZoltanFridrich approved these changes Nov 8, 2022
View reviewed changes
Copy link
Contributor

@ZoltanFridrich ZoltanFridrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont see any obvious problems in the code and the CI works. Looks good.

@ueno ueno force-pushed the wip/dueno/ci-macos branch from 864dbfb to 905d1ca Compare November 9, 2022 06:52
@ueno
Copy link
Member Author

ueno commented Nov 9, 2022

Thanks for the review!

@ueno ueno merged commit e3b3ced into p11-glue:master Nov 9, 2022
@ZoltanFridrich ZoltanFridrich added this to the 0.25.0 milestone Jun 28, 2023
@brisingraerowing brisingraerowing mentioned this pull request Jul 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZoltanFridrich ZoltanFridrich ZoltanFridrich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.25.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ueno @coveralls @ZoltanFridrich