Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: Use EXEEXT and SHLEXT #417

Merged
merged 2 commits into from
Jun 6, 2022
Merged

build: Use EXEEXT and SHLEXT #417

merged 2 commits into from
Jun 6, 2022

Conversation

ueno
Copy link
Member

@ueno ueno commented May 31, 2022

For better compatibility with Windows, append EXEEXT when spawning binary executables as well as replace ".so" with SHLEXT determined at build time.

@ueno ueno force-pushed the wip/dueno/exeext branch from 07bb9e4 to 4e6c2fa Compare June 1, 2022 23:32
@coveralls
Copy link

coveralls commented Jun 1, 2022 •
edited
Loading

Coverage Status

Coverage increased (+0.0006%) to 71.352% when pulling 615c553 on ueno:wip/dueno/exeext into 6add9dc on p11-glue:master.

@ueno ueno requested a review from ansasaki June 2, 2022 00:35
@ueno ueno force-pushed the wip/dueno/exeext branch from 4e6c2fa to 615c553 Compare June 3, 2022 08:30
ansasaki
ansasaki approved these changes Jun 6, 2022
View reviewed changes
Copy link
Contributor

@ansasaki ansasaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ueno ueno merged commit ce5a4f3 into p11-glue:master Jun 6, 2022
@ueno ueno added this to the 0.25.0 milestone Apr 6, 2023
@brisingraerowing brisingraerowing mentioned this pull request Jul 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ansasaki ansasaki ansasaki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.25.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ueno @coveralls @ansasaki