proxy: Support copying array of attributes #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daiki Ueno <[email protected]>
ueno
force-pushed
the
wip/dueno/attribute-array
branch
from
b49e5ac to
1a6f677
Compare
This enables p11_attrs_build to build an attribute list with arrays of attributes indicated with CKF_ARRAY_ATTRIBUTE. A couple of new internal functions have been added: p11_attr_copy and p11_attr_clear. Signed-off-by: Daiki Ueno <[email protected]>
ueno
force-pushed
the
wip/dueno/attribute-array
branch
from
1a6f677 to
b146127
Compare
|
@ansasaki would you perhaps like to review this? |
Yes, I can review |
|
Thank you! |
ansasaki
reviewed
Jul 15, 2021
|
Thanks for the review! |
|
autogen.sh |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously C_SetAttributeValue implementation in the proxy didn't copy array of attributes recursively and caused the subsequent C_GetAttributeValue receive the same memory address for the leaf attributes. This changes the behavior so the copying is always deep copy.