Solaris 10 #364
Solaris 10 #364
Conversation
configure.ac
Outdated
| @@ -173,6 +173,15 @@ if test "$os_unix" = "yes"; then | |||
| AC_MSG_RESULT([yes])], | |||
| [AC_MSG_RESULT([no])]) | |||
|
|
|||
| # Check if SUN_LEN is defined | |||
| AC_LINK_IFELSE([AC_LANG_PROGRAM([[#include <sys/un.h>]], | |||
There was a problem hiding this comment.
I would like to minimize the number of checks in configure, as we also maintain meson build. Is the #ifdef SUN_LEN check in compat.h insufficient for any reason?
There was a problem hiding this comment.
It should be sufficient if sys/un.h is included in compat or always included before.
There was a problem hiding this comment.
Updated the PR branch with that change
There was a problem hiding this comment.
@ueno any more feedback on this one, something you want me to fix?
There was a problem hiding this comment.
Thank you for the update and apologies for the delay; I somehow missed the notification.
|
Ok with this PR or are you waiting for me to provide something else? |
common/compat.h
Outdated
| @@ -39,6 +39,7 @@ | |||
|
|
|||
| #include <sys/types.h> | |||
| #include <sys/stat.h> | |||
| #include <sys/un.h> | |||
There was a problem hiding this comment.
In the mingw CI:
../common/compat.h:42:10: fatal error: sys/un.h: No such file or directory
42 | #include <sys/un.h>
| ^~~~~~~~~~I suppose a configure check is nevertheless needed :-(
There was a problem hiding this comment.
Ok, I'll update the PR
cp -v does not work on Solaris 10, nor does $() with /bin/sh so instead go for non verbose as -e will echo the commands performed anyway and use backticks.
Defining _XOPEN_SOURCE 700 on Solaris makes the compile fail due to a feature check in sys/feature_tests.h, C99 compiler in combination with < XPG6 feature set is not supported.
SUN_LEN is not available on Solaris 10, provide a fallback.
|
Thank you! |
A few compile fixes for Solaris 10.