proxy: Do not assign duplicate slot IDs #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ueno
requested changes
Feb 25, 2020
ansasaki
force-pushed
the
fix_slot_id_duplication
branch
from
54167b5 to
21574a1
Compare
ueno
reviewed
Feb 25, 2020
Previously, when re-mapping the slots, a slot ID could be assigned to more than one device, causing errors when searching for the right mapping (it would use the first found). Also assign new slot IDs for new found slots, avoiding previously used slot IDs. The last assigned slot ID is stored in the proxy structure in a new added field last_id. Signed-off-by: Anderson Toshiyuki Sasaki <[email protected]>
The test covers a case where duplicate slots IDs were assigned to two different slots in the mapping. Signed-off-by: Anderson Toshiyuki Sasaki <[email protected]>
ansasaki
force-pushed
the
fix_slot_id_duplication
branch
from
21574a1 to
b8c02eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supersedes #281
Previously, when assigning the slot IDs to the mapping, it could happen that new slots were listed by the module before slots previously seen. In this case duplicate slot IDs would be assigned to different slots.
This change makes all the reused slot IDs to be assigned before the new slot IDs. It also tries to make the slot IDs monotonically crescent.
A reproducer test case was added.
Fixes #266