import pyinotify on demand

[gzm55]

close #2

do not depend on pyinotify to work on macos

[codecov]

Codecov Report

Patch coverage has no change and project coverage change: +42.52% 🎉

Comparison is base (9fcc8a9) 46.84% compared to head (bf9964f) 89.36%.
Report is 2 commits behind head on master.

❗ Current head bf9964f differs from pull request most recent head afd1c41. Consider uploading reports for the commit afd1c41 to get more accurate results

Additional details and impacted files

@@             Coverage Diff             @@
##           master       #6       +/-   ##
===========================================
+ Coverage   46.84%   89.36%   +42.52%     
===========================================
  Files           4        3        -1     
  Lines         269      141      -128     
===========================================
  Hits          126      126               
+ Misses        143       15      -128     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[gzm55]

@p-sherratt could u plz take some minutes to review the recent pr?

[p-sherratt]

this removes the functionality of being able to open and read from the FIFO multiple times in one session, which I'd like to keep.

I'd like to see if watchdog library might help here-- need to test if's a viable abstraction for monitoring FIFO for both linux+mac, and maybe named pipes in windows.

also there could be a "time to live"/counter argument to limit the number of times the FIFO can be opened for reading -- in this case where we haven't implemented the monitoring for a given OS we can just enforce a value of 1.

[gzm55]

even for watchdog, the inotify backend cannot catch close_nowrite, changelog.

The ttl/counter feature would be great for security. But for compatible concern, it is better to default only write to fifo once and exit, with an additional runtime flag to enable the daemon fifo and load pyinotify on demand.

[gzm55]

a delete event of the output would be another signal to break the decrypt loop, i was used to write a POSIX shell version of re-readable fifo, exiting when found that the output fifo is removed.

[gzm55]

@p-sherratt add an option --writeonce to disable the daemon feature, and import the pyinotify on demand

[gzm55]

@p-sherratt any comments?

[gzm55]

@p-sherratt do you have time to review this pr?

[gzm55]

@p-sherratt hi, a gently ping~

[gzm55]

@p-sherratt pyinotify package is installed on linux only now. And with the new option --writeonce, the default actions keeps unchanged on linux.