Weight logic to Knockback #544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vrixyz
commented
Nov 17, 2019
Vrixyz
commented
Dec 2, 2019
|
Ok tests are not passing now, there must be something not deterministic in there, sometimes is succeeds and sometimes not, I guess the simplest fix is to split the test in 2 : "heavy" and "normal". I separated tests for "heavy" and "normal", but ❗️ there's no test to actually make sure the movement was indeed applied for "normal", but not applied for "heavy" |
ozkriff
requested changes
Jan 14, 2020
|
Could you rebase on top of the master branch (to fix Travis checks), please? |
|
Also, this PR should be paired with a PR to https://github.com/ozkriff/zemeroth_assets/blob/master/objects.ron otherwise the actual game crashes during initialization with a 'Can't parse the prototypes: Message("missing field `weight`")' msg. |
Vrixyz
force-pushed
the
291-weight-component
branch
from
9d48c59 to
a4b486a
Compare
Vrixyz
force-pushed
the
291-weight-component
branch
from
c7b8aac to
e7a0871
Compare
ozkriff
requested changes
Jan 20, 2020
ozkriff
approved these changes
Jan 22, 2020
|
Added a few final touches. Thanks for the PR again, @Vrixyz!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #291
Impacts would only be "BombPush" ability used on ally Heavy agents.
Features: