Skip to content

Commit

Permalink
Improve filter parameters for hi8
Browse files Browse the repository at this point in the history
  • Loading branch information
oyvindln committed Jun 28, 2023
1 parent ef51db2 commit 1ef6d3d
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions vhsdecode/format_defs/video8.py
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ def fill_rfparams_hi8_shared(rfparams):
# Temporary video emphasis filter constants
# Ideally we would calculate this based on tau and 'x' value, for now
# it's eyeballed based on graph and output.
rfparams["deemph_mid"] = 260000
rfparams["deemph_mid"] = 550000 # TODO: Not correct, needs to be fixed properly
rfparams["deemph_gain"] = 14

# Parameters for high-pass filter used for non-linear deemphasis, these are
Expand All @@ -89,15 +89,15 @@ def fill_rfparams_hi8_shared(rfparams):
rfparams["video_lpf_extra"] = 8810000
rfparams["video_lpf_extra_order"] = 3

rfparams["video_hpf_extra"] = 1520000
rfparams["video_hpf_extra_order"] = 1
rfparams["video_hpf_extra"] = 2520000
rfparams["video_hpf_extra_order"] = 3

# Low-pass filter on Y after demodulation
rfparams["video_lpf_freq"] = 5500000
rfparams["video_lpf_order"] = 1

# Video Y FM de-emphasis (1.25~1.35µs)
rfparams["deemph_tau"] = 1.30e-6
# Video Y FM de-emphasis
rfparams["deemph_tau"] = 0.47e-6 # From spec

# Filter to pull out high frequencies for high frequency boost
# This should cover the area around reference white.
Expand Down

0 comments on commit 1ef6d3d

Please sign in to comment.